Help Needed: code coverage decreasing due to unreleted files

soumajitghosh

soumajitghosh

New member
I'm seeing a code coverage drop of -5.71% on my pull request, and I'm trying to figure out the best way to fix it.

Codecov is flagging one file from my changes: src/screens/MemberDetail/MemberDetail.tsx.It says I have "0 Missing and 1 partial" line. I'm looking into that, and I assume it's an if statement or ternary operator that my test isn't fully covering.

I have two questions:
  1. Is this large 5.71% drop just because of my one partial line, or is it because my branch is so old and out of sync with develop?
  2. What is the correct way to fix this? Should I rebase my branch on develop first, and then fix the partial line? Or should I fix the partial line and then rebase?
Here is the link to my pull request for context: https://github.com/PalisadoesFoundation/talawa-admin/pull/4510

Thanks for the help!
 
That sometimes happens with CodeCov. The report is using a develop BASE that is two years old.

Always base your PRs on code that modifies the latest develop branch.
 
You must log in or register to reply here.
Back
Top